Add custom build backend to support build args #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a custom build backend, inspired by [the solution used by Pillow](python-pillow/Pillow#7171). The setuptools version requirement of 40.8.0 was also adopted from Pillow. It is the version that introduced the `build_meta:__legacy__` backend.
|
Ref #1679. |
loadams
reviewed
Jul 11, 2023
| @@ -1,6 +1,7 @@ | |||
| [build-system] | |||
| requires = [ | |||
| "setuptools", | |||
| "setuptools >= 40.8.0", | |||
| "wheel", | |||
There was a problem hiding this comment.
Is it worth adding packaging here or not?
There was a problem hiding this comment.
I left that to #1680 if that's fine.
loadams
approved these changes
Jul 11, 2023
|
I and others are still facing issues that this PR, coupled with #1680, would resolve. Is there anything I can do (testing, fix any remaining hangups, etc) to get this merged into upstream? |
|
@crcrpar - thoughts on merging this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a custom build backend, inspired by the solution used by Pillow.
--build-options aren't actually passed to thebuild_wheelcommand for reasons unknown to me. So this patchessetuptools.build_metato take the flags manually.The setuptools version requirement of 40.8.0 was also adopted from Pillow. It is the version that introduced the
build_meta:__legacy__backend.This actually fixes what #1690 meant to do and seems fully backward-compatible.