Allow env vars to specify custom extensions to build #1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This would be the first step to support build backends other than setuptools and make setup.py a little bit independent of the backend Signed-off-by: Masaki Kozuki <[email protected]>
crcrpar
force-pushed
the
env_vars_to_specify_extensions
branch
from
4edc2f9 to
7d80b19
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds environment-variable support for enabling Apex extensions under PEP 517 and allows configuring parallel build jobs via APEX_PARALLEL.
- Introduce
ENV_TO_FLAG,FLAG_TO_ENV, andhas_flagto drive extension modules from env vars. - Replace hardcoded
sys.argvchecks withhas_flagfor each extension flag. - Add
APEX_PARALLELenvironment variable handling for the--parallelbuild option.
Comments suppressed due to low confidence (3)
setup.py:49
- The new environment-variable to flag mapping and
has_flaglogic should have accompanying tests to verify that flags are correctly appended or skipped based on env settings.
for env_var, flag in ENV_TO_FLAG.items():
setup.py:85
- Add a docstring for
has_flagto explain that it checks bothsys.argv, the specific environment variable, andAPEX_ALL_CONTRIB_EXTfor contrib flags.
def has_flag(flag, env_var):
setup.py:1006
- The annotation
int | Nonerequires Python 3.10+ syntax and will fail to parse on earlier versions; useOptional[int]fromtypingfor broader compatibility.
parallel: int | None = None
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
Signed-off-by: Masaki Kozuki <[email protected]>
|
LGTM! With this PR in, what is the default/recommended installation command? |
nWEIdia
approved these changes
Jul 16, 2025
|
Env vars would be more modern than the apex's conventional install command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be the first step to support build backends other than setuptools and make setup.py a little bit independent of the backend, i.e., better compatibility with PEP517 and relevant PEPs.
With this we would be able to support some commands that have not been functioning well e.g.