-
Notifications
You must be signed in to change notification settings - Fork 222
tweak _CCCL_TRAILING_REQUIRES
macro so it can be used to constrain non-template member fns
#4865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ericniebler
wants to merge
5
commits into
NVIDIA:main
Choose a base branch
from
ericniebler:concept-macro-for-constrained-non-template-member-fn
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
tweak _CCCL_TRAILING_REQUIRES
macro so it can be used to constrain non-template member fns
#4865
ericniebler
wants to merge
5
commits into
NVIDIA:main
from
ericniebler:concept-macro-for-constrained-non-template-member-fn
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…non-template member fns
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
/ok to test ac613f7 |
🟨 CI finished in 2h 10m: Pass: 72%/187 | Total: 3d 15h | Avg: 28m 04s | Max: 1h 54m | Hits: 41%/154668
|
Project | |
---|---|
CCCL Infrastructure | |
CCCL Packaging | |
+/- | libcu++ |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
stdpar | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | CCCL Packaging |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | stdpar |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 187)
# | Runner |
---|---|
129 | linux-amd64-cpu16 |
15 | windows-amd64-cpu16 |
12 | linux-arm64-cpu16 |
12 | linux-amd64-gpu-rtxa6000-latest-1 |
11 | linux-amd64-gpu-rtx2080-latest-1 |
5 | linux-amd64-gpu-h100-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
/ok to test 73970f0 |
/ok to test 8dc09ee |
/ok to test 1509b3b |
🟨 CI finished in 2h 00m: Pass: 98%/187 | Total: 4d 22h | Avg: 38m 02s | Max: 1h 48m | Hits: 29%/286018
|
Project | |
---|---|
CCCL Infrastructure | |
CCCL Packaging | |
+/- | libcu++ |
+/- | CUB |
Thrust | |
+/- | CUDA Experimental |
stdpar | |
python | |
CCCL C Parallel Library | |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | CCCL Packaging |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | stdpar |
+/- | python |
+/- | CCCL C Parallel Library |
+/- | Catch2Helper |
🏃 Runner counts (total jobs: 187)
# | Runner |
---|---|
129 | linux-amd64-cpu16 |
15 | windows-amd64-cpu16 |
12 | linux-arm64-cpu16 |
12 | linux-amd64-gpu-rtxa6000-latest-1 |
11 | linux-amd64-gpu-rtx2080-latest-1 |
5 | linux-amd64-gpu-h100-latest-1 |
3 | linux-amd64-gpu-rtx4090-latest-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
c++20 concepts let you constrain non-template member functions of class templates, like:
but since we need to support c++17, we tend to write it like this:
this has the unfortunate side-effect of making the member function a template in c++20, where it doesn't need to be, and forcing the introduction of a dependent type that aliases
Base
.with some small changes to the
_CCCL_TEMPLATE
and_CCCL_TRAILING_REQUIRES
portability macros, we can now write it like this:in c++17, this expands to a function template with a trailing
enable_if
, and in c++20 it expands to a non-template with a trailing requires clause.also in this PR i moved the
->
out of the_CCCL_TRAILING_REQUIRES
macro. i prefer to see the->
in function signatures. i find it a helpful visual anchor in a sea of tokens.Checklist