Enable doc build workflow and build script for PR and Nightly #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
rgsl888prabhu
added
doc
jameslamb
requested changes
Jul 15, 2025
|
@jameslamb may I get another set of reviews on this ? |
jameslamb
previously requested changes
Jul 18, 2025
|
removed my blocking review, for the reasons mentioned in #199 (comment) Can help when I'm back if no one gets to it sooner, sorry. |
gforsyth
requested changes
Jul 21, 2025
There was a problem hiding this comment.
Looks good overall, @rgsl888prabhu !
Can you make this addition to the update-version-rapids.sh script? That will handle auto-updating the calver-tagged docker images:
diff --git a/ci/release/update-version-rapids.sh b/ci/release/update-version-rapids.sh
index 6835e25..72f3e7c 100755
--- a/ci/release/update-version-rapids.sh
+++ b/ci/release/update-version-rapids.sh
@@ -53,6 +53,8 @@ done
# WORKFLOWS
for FILE in .github/workflows/*.yaml; do
sed_runner "/shared-workflows/ s/@.*/@branch-${NEXT_SHORT_TAG}/g" "${FILE}"
+ # CI image tags of the form {rapids_version}-{something}
+ sed_runner "s/:[0-9]*\\.[0-9]*-/:${NEXT_SHORT_TAG}-/g" "${FILE}"
done
# CI
|
@gforsyth Added the changes |
gforsyth
approved these changes
Jul 21, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling doc build for PR and NIghtly workflow, this was disabled earlier since the documentation couldn't be built in github. But with OSS, documentation has changed.
Issue
closes #63
Checklist