Avoid HTTParty deprecation warnings on #nil? #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20.
The old version of
HTTParty::Responseimplements a custom implementation of#nil?that checks various properties of the body and raw response object. However, the project is interested in removing this method so that the class will behave more like other Ruby classes. (See jnunemaker/httparty#568.) In the meantime, they've put in a deprecation warning for anyone relying on the old custom behaviour.The
neverbounce-apigem isn't doing anything wrong by calling#nil?in the implementation of#require_attr, but by bad luck it's running afoul of the deprecation warning.This PR works around the warning by calling
== nilinstead of#.nil?on the attribute's value.