- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 567
 
[17.0][MIG] l10n_es_igic_verifactu_oca: Migration to 17.0 #4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM functional review
| if not company.chart_template_id: | ||
| coa = self.env.ref( | ||
| "l10n_es_igic.account_chart_template_pymes_canary", False | ||
| self.env["account.chart.template"].try_loading( | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esta fórmula es problemática, al menos en 18. Mira si esto otro sirve ya también en 17 y así ya no hay que cambiarlo luego:
| chart._load(template_code="es_pymes", company=company, install_demo=False) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajfebres Revisa lo que comenta Pedro y realiza las pruebas.
| 
           /ocabot migration l10n_es_igic_verifactu_oca  | 
    
| 
           El CI está en rojo  | 
    
Nota legal y de cumplimiento
Este cambio mantiene la conformidad con la normativa aplicable al sistema
VERI*FACTU, conforme a lo establecido en:
Reglamento que establece los requisitos que deben adoptar los sistemas
informáticos o electrónicos que soporten los procesos de facturación.
La modificación tiene carácter exclusivamente técnico y no altera la
estructura, integridad ni trazabilidad de los registros de facturación
ni el cumplimiento de las obligaciones establecidas por la AEAT.