[18.0][IMP]partner_industry_secondary - test_res_partner_industry.py #2067
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
apami0111
commented
May 30, 2025
apami0111
commented
- Replaced assertRaises with assertRaisesRegex to validate specific error messages.
- Added docstrings to each test case for better clarity and documentation.
celm1990
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
LGTM, thanks for the improvements.
@pedrobaeza, could you please review this?
|
Why changing ValidationError by UserError? |
apami0111
force-pushed
the
18.0-imp-partner_inductry_scundary-improve_test
branch
2 times, most recently
from
8f61a25 to
27762ba
Compare
- Replaced assertRaises with assertRaisesRegex to validate specific error messages. - Added docstrings to each test case for better clarity and documentation.
|
Thank you very much for your feedback! @pedrobaeza |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 29cea11. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.