Skip to content

Conversation

rahulpatel333
Copy link

Summary: Introduces datepicker filter in POS order list.
Type: [ADD]
Tested on: Odoo 18 CE.
Screenshot:
screenshot

@rahulpatel333 rahulpatel333 changed the title [ADD] pos_order_datepicker: add datepicker filter in POS order list [18.0][ADD] pos_order_datepicker: add datepicker filter in POS order list Sep 6, 2025
Copy link

@adasatorres adasatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Code review and functional review in the runboat, the only thing missing is for the tests not to fail.

Copy link

@jelenapoblet jelenapoblet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it through runboat and it works as spected, simple yet usefull. Works as expected.

@jelenapoblet
Copy link

I noticed that the README file doesn’t fully follow the recommended structure. You can check the guide here: https://odoo-community.org/readme-structure
As a note, if you follow the instructions in that guide, there’s a built-in pre-commit script in the repository that will automatically generate the README in the correct format.

@adasatorres
Copy link

adasatorres commented Sep 13, 2025

Good evening @rahulpatel333 , I recommend squashing all commits. This is generally required to maintain a clean and consistent commit history. Please refer to the following link, which provides a clear explanation of the process:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests

Copy link

@adasatorres adasatorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary to remove the other addons.

@rahulpatel333
Copy link
Author

It is not necessary to remove the other addons.

My module is completely separate from the other modules in the repository. Since their test cases were failing, my module’s tests were also being marked as failed. That’s why I removed the other modules to ensure my module’s tests could pass independently.

@rahulpatel333 rahulpatel333 force-pushed the 18.0-pos-order-datepicker branch from 284be91 to 4b20bd1 Compare September 14, 2025 11:01
@adasatorres
Copy link

My module is completely separate from the other modules in the repository. Since their test cases were failing, my module’s tests were also being marked as failed. That’s why I removed the other modules to ensure my module’s tests could pass independently.

The solution should not be to remove the addons, as they would be deleted from the repository if the PR is merged. The correct approach would be to open a PR to fix the tests for each addon. Once the fixes are merged into the 18.0 branch in this case, you should perform a rebase and bring the changes from the repository into the branch you are using for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants