-
-
Notifications
You must be signed in to change notification settings - Fork 658
[18.0][ADD] pos_order_datepicker: add datepicker filter in POS order list #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Code review and functional review in the runboat, the only thing missing is for the tests not to fail.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it through runboat and it works as spected, simple yet usefull. Works as expected.
I noticed that the README file doesn’t fully follow the recommended structure. You can check the guide here: https://odoo-community.org/readme-structure |
Good evening @rahulpatel333 , I recommend squashing all commits. This is generally required to maintain a clean and consistent commit history. Please refer to the following link, which provides a clear explanation of the process: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not necessary to remove the other addons.
My module is completely separate from the other modules in the repository. Since their test cases were failing, my module’s tests were also being marked as failed. That’s why I removed the other modules to ensure my module’s tests could pass independently. |
284be91
to
4b20bd1
Compare
The solution should not be to remove the addons, as they would be deleted from the repository if the PR is merged. The correct approach would be to open a PR to fix the tests for each addon. Once the fixes are merged into the 18.0 branch in this case, you should perform a rebase and bring the changes from the repository into the branch you are using for the PR. |
Summary: Introduces datepicker filter in POS order list.

Type: [ADD]
Tested on: Odoo 18 CE.
Screenshot: