Do not merge: ModelContainer memory leak review #1470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Konstantin's commit: kosinsky@40020a1#diff-5449bed3a006bfaa5c95f3959bf4cb96R574 |
|
Other things to try:
|
AlanWong-MS
commented
Jun 11, 2018
| // Exception: | ||
| // NotSupportedException: Unable to create a constant value of type 'Microsoft.OData.Edm.EdmModel'. Only primitive types or enumeration types are supported in this context. | ||
| // | ||
| // Sample E2E test that fails: NestedTopSkipOrderByInDollarExpandWorksWithEF |
There was a problem hiding this comment.
DerivedAutoExpandNavigationPropertyTest fails and goes through the EnableQueryAttribute.cs
|
Closing in favor of #1506. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #1462
Issue #1101