Relax Clang compiler requirement #12834
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang 16 is perfectly capable of compiling the current code base. The actual constraint is the standard library being used, but there is no CMake feature to test the standard library version. Thus, this commit makes this requirement explicit in the documentation, and implicit in the build system.
|
Thanks for your suggestion. I think that you mix Apple Clang version with Clang version, and we struggle to keep the documentation as compact as possible. At this point our major supported systems are Windows and Linux, we might add more documentation and support for Apple/Mac later. |
SoilRos
commented
Sep 2, 2025
| @@ -33,10 +33,10 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") | |||
| endif() | |||
|
|
|||
| if(CMAKE_CXX_COMPILER_ID MATCHES "Clang") | |||
There was a problem hiding this comment.
@magnesj Ah thanks, you are absolutely right about the AppleClang Version! Meaning that this line is overdelivering: It should be STREQUAL instead of MATCHES, otherwise it wrongly matches with AppleClang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang 16 is perfectly capable of compiling the current code base. The actual constraint is the standard library being used (see #12655 (comment)), but there is no CMake feature to test the standard library version. Thus, this commit makes this requirement explicit in the documentation, and implicit in the build system.