-
Notifications
You must be signed in to change notification settings - Fork 206
chromium: Reduce minimum browser window width to 480px #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The TST043015CNHX panel is a 480x272 panel. Chromium browser limits the minimum window width to 500px since commits: 6b0ecc1e4532c ("Set lower bound on contents pane size.") 580d6900dc7fc ("In tab dragging, the window size should be larger than its minimum size.") To make chromium browser usable on those tiny panels as well, reduce the minimum window width to 480px. The upstreaming of this change is in progress. Signed-off-by: Marek Vasut <[email protected]>
Is there a CL in Gerrit or an upstream bug report you can refer to? I'm weary of taking this patch in without more information, as the new size also looks somewhat arbitrary from a meta-chromium perspective. |
@rakuco I sent the patch to the authors of the aforementioned two commits via email as the chromium contribution guidelines are difficult for such a one-liner . I cannot tell whether they created a crbug from that, sorry, but this one https://bugs.chromium.org/p/chromium/issues/detail?id=875197 is very much the same issue (and probably any other crbug which mentions "500px" in some width context) |
I support the addition of a workaround for this, but we need a long-term vision to remove the workaround. @rakuco, can you fix this upstream? |
I support adding this patch. @rakuco ? |
I realize this PR was opened over a year ago, but I would also like to know if there is a plan to support this patch? I am building a BSP for a touchscreen device where the configured fullscreen state is 480x800px. Chromium in kiosk/fullscreen mode would fail to launch until I applied this patch. I had similar errors as this bug: #733. |
I am fine and change the default. Could you release and test it? |
The TST043015CNHX panel is a 480x272 panel. Chromium browser limits the minimum window width to 500px since commits:
6b0ecc1e4532c ("Set lower bound on contents pane size.")
580d6900dc7fc ("In tab dragging, the window size should be larger than its minimum size.")
To make chromium browser usable on those tiny panels as well, reduce the minimum window width to 480px. The upstreaming of this change is in progress.