[IMP] Add getter for floats and avoid NullPointerExceptions in OValues #329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As OValues are closely related to ODataRecords which are using float values, there should also be a getter for float values for OValues. As all getters in OValues were using the wrapper classes for the primitive data types, this commit also changes the return type for long values to 'Long'. Until now, a NullPointerException has been thrown if someone tried to use the typed getters in OValues for non-existant keys. This has been changed as well. Instead, the methods are returning the same value as if the value of the field would have been 'false'.
|
Another suggestion. As we are already returning the wrapper classes Integer, Float etc. it would probably make more sense to return "null" if the value is 'false' or the key does not exist. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As OValues are closely related to ODataRecords which are using float values,
there should also be a getter for float values for OValues.
As all getters in OValues were using the wrapper classes for the primitive data
types, this commit also changes the return type for long values to 'Long'.
Until now, a NullPointerException has been thrown if someone tried to use the
typed getters in OValues for non-existant keys. This has been changed as well.
Instead, the methods are returning the same value as if the value of the field
would have been 'false'.