Skip to content

Instrument the CALL, CALLCODE, DELEGATECALL and STATICCALL opcodes #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 21, 2025
Merged

Instrument the CALL, CALLCODE, DELEGATECALL and STATICCALL opcodes #486

merged 9 commits into from
Jul 21, 2025

Conversation

MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Jul 11, 2025 •
edited
Loading

For NIT-3483 and NIT-3480

Instrument CALL and CALLCODE opcode with multigas calculations:

  • Base gasCall func
  • Base gasCallCode func
  • makeCallVariantGasCallEIP2929 for EIP-2929 (access lists)
  • makeCallVariantGasEIP4762 for EIP-4762 (Verkle trees)
  • makeCallVariantGasCallEIP7702 for EIP-7702 (set code transaction)
  • Base gasDelegateCall func
  • Base gasStaticCall func

@cla-bot cla-bot bot added the s CLA signed label Jul 11, 2025
@MishkaRogachev MishkaRogachev changed the title Instrument gasCall with multi gas Instrument the CALL and CALLCODE opcodes Jul 11, 2025
@MishkaRogachev MishkaRogachev force-pushed the instrument_call_gas_func branch from e66c1e6 to 3e5a9fd Compare July 11, 2025 14:54
MishkaRogachev
MishkaRogachev commented Jul 11, 2025
View reviewed changes
@MishkaRogachev MishkaRogachev force-pushed the instrument_call_gas_func branch 2 times, most recently from e99cca4 to 487493b Compare July 14, 2025 17:54
@MishkaRogachev MishkaRogachev changed the title Instrument the CALL and CALLCODE opcodes Instrument the CALL, CALLCODE, DELEGATECALL and STATICCALL opcodes Jul 15, 2025
MishkaRogachev
MishkaRogachev commented Jul 15, 2025
View reviewed changes
@MishkaRogachev MishkaRogachev marked this pull request as ready for review July 15, 2025 11:49
@MishkaRogachev MishkaRogachev requested review from eljobe and tsahee July 15, 2025 11:50
eljobe
eljobe requested changes Jul 15, 2025
View reviewed changes
@eljobe eljobe assigned MishkaRogachev and unassigned eljobe Jul 15, 2025
@MishkaRogachev MishkaRogachev force-pushed the instrument_call_gas_func branch from 0f1ce7a to ca34cf3 Compare July 15, 2025 14:01
@MishkaRogachev MishkaRogachev force-pushed the instrument_call_gas_func branch from ca34cf3 to 0665b84 Compare July 17, 2025 10:29
@MishkaRogachev MishkaRogachev mentioned this pull request Jul 17, 2025
Merged
2 tasks
@MishkaRogachev MishkaRogachev changed the base branch from master to cbp-feature July 18, 2025 11:17
@MishkaRogachev MishkaRogachev mentioned this pull request Jul 18, 2025
Merged
1 task
eljobe
eljobe requested changes Jul 18, 2025
View reviewed changes
@eljobe eljobe assigned MishkaRogachev and unassigned eljobe Jul 18, 2025
eljobe
eljobe previously approved these changes Jul 21, 2025
View reviewed changes
@eljobe eljobe enabled auto-merge July 21, 2025 12:32
@MishkaRogachev MishkaRogachev changed the base branch from cbp-feature to master July 21, 2025 12:47
@MishkaRogachev MishkaRogachev dismissed eljobe’s stale review July 21, 2025 12:47

The base branch was changed.

@eljobe eljobe merged commit 22d80fc into master Jul 21, 2025
7 checks passed
@eljobe eljobe deleted the instrument_call_gas_func branch July 21, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relyt29 relyt29 relyt29 left review comments

@eljobe eljobe eljobe approved these changes

@tsahee tsahee Awaiting requested review from tsahee

@gligneul gligneul Awaiting requested review from gligneul

Assignees

@eljobe eljobe

Labels
design-approved s CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MishkaRogachev @eljobe @relyt29 @gligneul