Skip to content

Fix ProcessScheduler memleak #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix ProcessScheduler memleak #1053

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
179b516
Fix ProcessScheduler memleak
Oct 4, 2023
2502eb3
feat: use time span for replay buffer
ccheetham Oct 5, 2023
da5856b
Merge pull request #1 from ccheetham/fix/memleak
antpensi Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/JsonRpc/ProcessScheduler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ IScheduler scheduler

var observableQueue =
new BehaviorSubject<(RequestProcessType type, ReplaySubject<IObservable<Unit>> observer, Subject<Unit>? contentModifiedSource)>(
( RequestProcessType.Serial, new ReplaySubject<IObservable<Unit>>(int.MaxValue, Scheduler.Immediate), supportContentModified ? new Subject<Unit>() : null )
( RequestProcessType.Serial, new ReplaySubject<IObservable<Unit>>(TimeSpan.FromSeconds(6), Scheduler.Immediate), supportContentModified ? new Subject<Unit>() : null )
);

cd.Add(
Expand All @@ -52,7 +52,7 @@ IScheduler scheduler

logger.LogDebug("Completing existing request process type {Type}", observableQueue.Value.type);
observableQueue.Value.observer.OnCompleted();
observableQueue.OnNext(( item.type, new ReplaySubject<IObservable<Unit>>(int.MaxValue, Scheduler.Immediate), supportContentModified ? new Subject<Unit>() : null ));
observableQueue.OnNext(( item.type, new ReplaySubject<IObservable<Unit>>(TimeSpan.FromSeconds(6), Scheduler.Immediate), supportContentModified ? new Subject<Unit>() : null ));
}

logger.LogDebug("Queueing {Type}:{Name} request for processing", item.type, item.name);
Expand Down