Skip to content

Conversation

wabicai
Copy link
Contributor

@wabicai wabicai commented Sep 28, 2025

Summary by CodeRabbit

  • Chores

    • Upgraded OneKey SDK packages to version 1.1.15-alpha.0 to align with the latest hardware libraries.
    • Updated the hardware connection endpoint to use the new SDK source.
  • Notes

    • No user-facing behavior changes are expected from this update.
    • Improves compatibility with the latest hardware SDK versions.

Copy link

coderabbitai bot commented Sep 28, 2025

Walkthrough

Updated OneKey SDK versions from 1.1.13 to 1.1.15-alpha.0 in dependencies and switched the hardware connectSrc URL to the matching 1.1.15-alpha.0 endpoint. No other code or API signatures changed.

Changes

Cohort / File(s) Summary
Dependency version bumps
package.json
Bumped @onekeyfe/hd-core, @onekeyfe/hd-shared, and @onekeyfe/hd-web-sdk from 1.1.13 to 1.1.15-alpha.0.
Hardware SDK endpoint update
src/hardware/instance.ts
Updated HardwareSDK init to use connectSrc URL for 1.1.15-alpha.0; other init params unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title claims to add “emmc filewrite in boot” support, but the diff only bumps the OneKey SDK to version 1.1.15-alpha.0 and updates its connectSrc endpoint without any changes related to eMMC or boot file writing. Rename the title to reflect the actual change, for example “chore: bump OneKey SDK to 1.1.15-alpha.0” or “feat: upgrade connectSrc endpoint to 1.1.15-alpha.0” so it matches the SDK version update in this PR.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/support-emmcwrite

Comment @coderabbitai help to get the list of available commands and usage tips.

@revan-zhang
Copy link
Contributor

revan-zhang commented Sep 28, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

Copy link

@wabicai wabicai enabled auto-merge (squash) September 28, 2025 09:12
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2e8cdd7 and 8b51b1c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/hardware/instance.ts (1 hunks)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants