<fix>: Improve the compatibility of shell.nix for different versions of Nix; fix overflow issue of micropython

[Johnwanzi]

Summary by CodeRabbit

• Chores

  • Updated environment configuration to use SDL2 and SDL2_image from the main package set, with platform-specific adjustments.
  • Improved flexibility for selecting the pyright package based on local directory presence.

• Refactor

  • Increased the size of the MicroPython pystack for enhanced performance and stability in the Unix embedding.

[coderabbitai]

Walkthrough

The updates adjust the Nix shell configuration by changing how SDL2 dependencies and the Pyright package are imported. The SDL2 packages now come from the main nixpkgs set on non-Darwin platforms. Pyright is conditionally imported based on directory presence. Separately, the MicroPython pystack array size in the Unix embed code increases from 1024 to 4096 elements.

Changes

File(s)	Change Summary
ci/shell.nix	Switch SDL2 imports to main nixpkgs on non-Darwin; add conditional import for Pyright based on directory presence.
core/embed/unix/main.c	Increase MicroPython pystack array size from 1024 to 4096 elements.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NixShell
    participant FileSystem

    User->>NixShell: Start shell
    NixShell->>FileSystem: Check if ./pyright exists
    alt ./pyright exists
        NixShell->>NixShell: Import pyright from ./pyright
    else
        NixShell->>NixShell: Import pyright from ./ci/pyright
    end
    NixShell->>NixShell: Import SDL2, SDL2_image from nixpkgs or sdlnixpkgs based on platform

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3870ff7 and c737444.

📒 Files selected for processing (1)

• ci/shell.nix (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Gen check
• GitHub Check: Defs check
• GitHub Check: Analyze (python)
• GitHub Check: Style check

🔇 Additional comments (3)

ci/shell.nix (3)

60-64: LGTM! Clean conditional pyright import logic.

The conditional import mechanism handles missing pyright directories gracefully. The logic correctly falls back to ./ci/pyright when the local ./pyright directory doesn't exist.

---

103-104: Good fix for SDL2 compatibility on non-Darwin platforms.

Using SDL2 packages directly from the main nixpkgs resolves the compatibility issues mentioned in the past review comments. This should eliminate the undefined symbol problems when mixing SDL libraries from different nixpkgs versions.

---

110-111: Preserves working SDL2 setup for Darwin platforms.

Keeping sdlnixpkgs.SDL2 for Darwin platforms maintains the working configuration while fixing issues on other platforms. This platform-specific approach makes sense given the different compatibility requirements.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.