feat(logging): add public log listener methods #1580
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Adds the following new public methods to allow an app developer to capture logs as strings at runtime.
Details
This is a copy of changes in #1576
Adds the following new public methods:
OneSignal.Debug.addLogListener
OneSignal.Debug.removeLogListener
These new methods provide a way to capture all SDK log entires at runtime, allowing the app developer to store these and/or send them to their server.
The log listener is independent of logLevel, all message are always sent to listeners.
Sample Usage
Motivation
App developers want a way to capture all SDK logs and send them to their server to debug issues in production.
Scope
Only add new methods to OneSignal.Debug to allow of capturing logs at runtime.
Create new OSCopyOnWriteSet class
Testing
Unit testing
Added LoggingTests
Manual testing
Tested on an iPhone 13, tested concurrent modification of log listeners array as well (within the same thread and from multiple threads)
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is