GDB-12871 bundle all plugins for easier loading #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the webpack configuration to bundle all plugins into a single file for easier loading. It replaces the previous approach of generating individual plugin entry points using glob patterns with a new bundled approach using a central plugins-bundle.js file that auto-discovers and registers all plugins.
- Modified webpack config to use a single entry point instead of glob-based individual plugin files
- Created a new plugins bundle file with auto-discovery functionality for plugin registration
- Updated webpack optimization settings to prevent code splitting
- Updated documentation generation reflecting the bundled plugin structure
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| webpack.config.js | Changes entry point from glob-discovered individual files to single bundle, adds optimization settings to prevent splitting |
| plugins/plugins-bundle.js | New auto-discovery bundle file that finds and registers all plugins using webpack context |
| scripts/post-jsdoc.js | Minor code style update (arrow function formatting) |
| docs/*.html | Generated documentation updates reflecting the new bundled structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
boyan-tonchev
force-pushed
the
GDB-12871-bundle-plugins-for-loading-optimization
branch
from
c1c984d to
baee64f
Compare
boyan-tonchev
force-pushed
the
GDB-12871-bundle-plugins-for-loading-optimization
branch
2 times, most recently
from
c932b50 to
74dde4e
Compare
|
|
||
| // Public API: register all discovered plugins. | ||
| export function register(registry) { | ||
| for (const register of registerFns) register(registry); |
There was a problem hiding this comment.
expand this for cycle with curly braces
## What - Replace per-plugin packaging with a single bundled file. - Update the plugins manifest to describe the bundled package instead of individual plugins. ## Why Previously, each plugin required its own network request. Bundling reduces this to a single request, improving load performance. ## How A script was added that iterates through all plugin modules and collects them into an array. It then creates a module with a register function, which loops over the array of plugin modules and registers each one in sequence. This PR changes the webpack configuration to bundle all plugins into a single file for easier loading. It replaces the previous approach of generating individual plugin entry points using glob patterns with a new bundled approach using a central plugins-bundle.js file that auto-discovers and registers all plugins. Modified webpack config to use a single entry point instead of glob-based individual plugin files Created a new plugins bundle file with auto-discovery functionality for plugin registration Updated webpack optimization settings to prevent code splitting
boyan-tonchev
force-pushed
the
GDB-12871-bundle-plugins-for-loading-optimization
branch
from
74dde4e to
fe68f65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Previously, each plugin required its own network request. Bundling reduces this to a single request, improving load performance.
How
A script was added that iterates through all plugin modules and collects them into an array. It then creates a module with a register function, which loops over the array of plugin modules and registers each one in sequence.
This PR changes the webpack configuration to bundle all plugins into a single file for easier loading. It replaces the previous approach of generating individual plugin entry points using glob patterns with a new bundled approach using a central plugins-bundle.js file that auto-discovers and registers all plugins.
Modified webpack config to use a single entry point instead of glob-based individual plugin files
Created a new plugins bundle file with auto-discovery functionality for plugin registration
Updated webpack optimization settings to prevent code splitting