Skip to content

Implement FileClient2 progress callbacks #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

chemicstry
Copy link
Contributor

I will leave this as draft until OpenCyphal/yakut#119 is finished, in case any additional changes are needed

path: str,
offset: int = 0,
size: typing.Optional[int] = None,
progress: typing.Optional[typing.Callable[[int, int], None]] = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code you're editing was written a long time ago. Now the recommended syntax is int | None instead of Optional[int], Callable[[int, int], None] | None, memoryview | bytes, etc. I'm not saying you need to update existing code but if you're editing something that uses old-style annotations it would be nice to replace them.

@coveralls
Copy link

coveralls commented May 19, 2025

Coverage Status

coverage: 94.346% (+0.02%) from 94.328%
when pulling e94c1d3 on chemicstry:file_client_progress
into eda263e on OpenCyphal:master.

@chemicstry chemicstry marked this pull request as ready for review May 19, 2025 13:55
@pavel-kirienko
Copy link
Member

Thank you. I moved your changes to #354 and I am going to merge it next.

pavel-kirienko added a commit that referenced this pull request May 21, 2025
Supersedes #353

---------

Co-authored-by: chemicstry <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants