Skip to content

Create 1.0.0.schema.json #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Create 1.0.0.schema.json #42

wants to merge 13 commits into from

Conversation

srappel
Copy link
Member

@srappel srappel commented Feb 5, 2024

Addresses #41

Adds a JSON Schema file for Specification 1.0.0 which will help GeoBlacklight development better integrate OpenIndexMaps.

I had ChatGPT do a lot of the drafting, but it seems to validate fine. And despite saying that we have no required elements, I've included label, north, south, east, and west. Open to suggestions about this.

@srappel
Copy link
Member Author

srappel commented Feb 5, 2024

There's a general GeoJSON schema file here. We might want to take a look and compare.

@kgjenkins
Copy link
Contributor

I'm not sure about requiring north/south/east/west elements.

For typical rectangle-based index maps, these values are redundant with the information found in the geometry.
For point-based index maps (like aerial photo centroids), there will be no NSEW elements.

Looking at the GBL code, I don't think GBL actually requires any elements except the geometry. However, basic functionality would require "label" (although GBL will handle null).

@srappel
Copy link
Member Author

srappel commented Apr 11, 2024

Thats a good point about the point features. And if GBL can handle null in the label field, then I think we can move forward with no required elements. Reminding myself this means we need to explicitly allow null for these elements.

@srappel
Copy link
Member Author

srappel commented May 31, 2024

At Geo4LibCamp we thought it would be useful to make the JSON Schema file a bit more restrictive about foreign member elements. Some fields like websiteUrl had been incorrectly entered as websiteURL which did not flag the validation but did break GeoBlacklight. That's what these last few commits are about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants