Fix cross compilation for x86 targets from non-x86 #5495
Merged
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building on a non-x86 host the Makefile definitions for HAVE_* are never printed which leads to build failures and/or silently targeting the wrong microarchitecture. The issue is that INTEL_AMD is defined if the host architecture is x86, but for cross builds we need to test whether the target is x86. Test for that using the macro FORCE_INTEL.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building on a non-x86 host the Makefile definitions for HAVE_* are never printed which leads to build failures and/or silently targeting the wrong microarchitecture. The issue is that INTEL_AMD is defined if the host architecture is x86, but for cross builds we need to test whether the target is x86. Test for that using the macro FORCE_INTEL.