feat: Add vLLM V1 support w/Unsloth model service #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a few current limitations with Unsloth Zoo that disallow V1 support. Generally, Unsloth Zoo does not support V1's collective RPC pattern yet. The collective RPC call to get the weight IPC handles failed with |
|
I'm not seeing any chatter on the Unsloth side about working towards this. How hard would it be to do it ourselves? |
|
Hard to say, could take a while. |
|
Probably will end up closing this if decoupling vLLM & Unsloth works out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the Unsloth model service to also support vLLM V1 which has some performance improvements and is the future of vLLM development.