-
Notifications
You must be signed in to change notification settings - Fork 129
Update goal-posts regarding extension management #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
merge Better testing utilities for extension development with Better support for OpenRefine extensions
✅ Deploy Preview for openrefine-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense, especially at this stage where both goal posts need a solution definition. It feels appropriate to have "better testing utilities" as a requirement for better support for extensions rather than a standalone goal post.
I wouldn't personally merge these as I imagine the work involved would be very different. The first point clearly needs work and consensus building in OpenRefine core. For the one about test-ability however, I would imagine that the vast majority of the work would happen outside of OpenRefine core. Arguably, OpenRefine/CommonsExtension#157 and related PRs implemented a lot of the second goal post, so we should probably update the description. |
The reason behind my approval is that I think the "better support for extensions" goal post will already involve multiple streams of work, and support for testing extensions falls under the umbrella of providing better overall support for extension developers. That said, I don't have a strong opinion on merging these two and I agree that it's possible for some of the current goal posts to grow so much as to become unwieldy. |
My opinion from the sidelines here. Goal posts are goals. Think "We want to go to the moon." In order to accomplish that goal, everyone agrees that lots of work needs to be done. Specs written, new bolts designed for the new machines that will make the new fins for the new rocket. I.E. Goal posts are SMALL summaries describing GIANT amounts of work. I think as long as each small summary describes its goal like "Win WWII", etc. then issues and design docs can and should be used with labeling that shows they are a part of addressing some goal post. Example: "Addresses Recon Scoring part for goal: Make Recon Better" Furthermore, GitHub has improved immensely and now has sub-issues. Let's ensure we use those to scope and gather the GIANT work needed for each single goal. |
Thanks for your input, Thad! Something I think would be useful is to have a tag on the forum for goal post-related threads. That way, it'd be easier to link conversations there with goal posts here. Hopefully that would make it easier to stay on top of the discussion resulting from the larger goals while allowing discussions to go deep on a particular facet of one goal post. |
revert goal post merging and add more details
Thanks @thadguidry for very clearly summarizing the intention behind goalpost. @Abbe98 I updated the page to keep the two goals separate.
|
Merge Better testing utilities for extension development with Better support for OpenRefine extensions
@SoryRawyer @wetneb @Abbe98 let me know if it makes sense to merge those two goal post or if we should keep them separated.