ezbake: Introduce service-port variable #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables ezbake to use the port in templates, e.g. rendering the systemd unit file. This is required to add a post start command to check if the tcp port is already reachable.
bastelfreak
added a commit
to bastelfreak/ezbake
that referenced
this pull request
Aug 4, 2025
This adds a bit of a startup delay to ensure that systemd not just starts the process and thinks the service is already up and running. Previously this was handled by the wrapper script and Type=forking. This commit fixes a regression from OpenVoxProject@b2de7c7 This also requires changes to the projects to provide the actual port. * OpenVoxProject/openvox-server#80 * OpenVoxProject/openvoxdb#69 This is just a workaround and not a perfect solution. For systemd-based systemd we should implement sd_notify and switch to Type=notify-reload. https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Type=
|
We first need to merge OpenVoxProject/ezbake#37, otherwise CI won't pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables ezbake to use the port in templates, e.g. rendering the systemd unit file. This is required to add a post start command to check if the tcp port is already reachable.