Skip to content

CI: Test jruby-9.4.3 #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

bastelfreak
Copy link
Contributor

We have some weird JRuby issues on main. Previously we pinned to JRuby-9.4 on Ubuntu-24.04. That currently gives us https://github.com/ruby/ruby-builder/releases/download/toolcache/jruby-9.4.13.0-ubuntu-24.04.tar.gz

The old Perforce CI was pinned to jruby-9.4.3.0 on Ubuntu 22.04, lets try that.

@bastelfreak
Copy link
Contributor Author

9.4.3:

Finished in 13 minutes 14 seconds
24007 examples, 15 failures, 50 pending

9.4.8:

Finished in 13 minutes 21 seconds
24007 examples, 39 failures, 33 pending

9.4.13:

Finished in 13 minutes 13 seconds
24007 examples, 39 failures, 33 pending

@bastelfreak
Copy link
Contributor Author

nest run with more jrubies:

9.4.3:

Finished in 13 minutes 18 seconds
24007 examples, 15 failures, 50 pending

9.4.4:

Finished in 13 minutes 14 seconds
24007 examples, 16 failures, 49 pending

9.4.5:

Finished in 14 minutes 27 seconds
24007 examples, 16 failures, 49 pending

9.4.6:

Finished in 12 minutes 53 seconds
24007 examples, 39 failures, 33 pending

9.4.7:

Finished in 13 minutes 4 seconds
24007 examples, 39 failures, 33 pending

9.4.8:

Finished in 15 minutes 12 seconds
24007 examples, 39 failures, 33 pending

9.4.13

Finished in 13 minutes 32 seconds
24007 examples, 39 failures, 33 pending

@bastelfreak
Copy link
Contributor Author

Perforce used bundle exec rake parallel:spec[2]. Lets see if there are some race conditions and switch from bundle exec rake parallel:spec to bundle exec rake parallel:spec[2].

@bastelfreak
Copy link
Contributor Author

ok with bundle exec rake parallel:spec[2]

9.4.3:

Finished in 12 minutes 34 seconds
24007 examples, 15 failures, 50 pending

9.4.4:

Finished in 12 minutes 27 seconds
24007 examples, 16 failures, 49 pending

9.4.5:

Finished in 12 minutes 22 seconds
24007 examples, 16 failures, 49 pending

9.4.6:

Finished in 12 minutes 43 seconds
24007 examples, 39 failures, 33 pending

9.4.7:

Finished in 12 minutes 44 seconds
24007 examples, 39 failures, 33 pending

9.4.8:

Finished in 12 minutes 55 seconds
24007 examples, 39 failures, 33 pending

9.4.13:

Finished in 12 minutes 53 seconds
24007 examples, 39 failures, 33 pending

The JSON gem has historically included newlines when pretty printing
empty arrays or hashes. This changed with ruby/json@b2c4480 in JSON
2.8.0.

In order to maintain consistent behavior for our users, this commit
special cases empty array and hash facts and adds a new test for empty
hashes.
We have some weird JRuby issues on main. Previously we pinned to
JRuby-9.4 on Ubuntu-24.04. That currently gives us
https://github.com/ruby/ruby-builder/releases/download/toolcache/jruby-9.4.13.0-ubuntu-24.04.tar.gz

The old Perforce CI was pinned to jruby-9.4.3.0 on Ubuntu 22.04, lets
try that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants