Skip to content

Conversation

nmburgan
Copy link
Member

@nmburgan nmburgan commented Sep 8, 2025

Version 8.23.0 of the agent updated fast_gettext to 4.1.0, which broke
r10k since it depends on gettext-setup, which pins fast_gettext to ~>
2.1. This simulates this upgrade condition. However, we should more
robustly test upgrades at some point in the future.

This test will fail with 8.23.0 and should pass on 8.23.1 when it’s ready

@nmburgan
Copy link
Member Author

nmburgan commented Sep 8, 2025

The r10k test isn't failing. Hmm.

@nmburgan
Copy link
Member Author

nmburgan commented Sep 8, 2025

Actually, we already have a pretty in-depth service test, and that never popped before. I wonder if it's not installing the version we think it is.

@nmburgan nmburgan force-pushed the r10k_service_tests branch 2 times, most recently from 2063170 to da6164f Compare September 8, 2025 16:24
@nmburgan
Copy link
Member Author

nmburgan commented Sep 8, 2025

It might have something to do with r10k being in Bolt, or something getting fast_gettext 2.4 in there before 4.1 goes down and it just falls back to 2.4. I verified the agent version is fine.

@bastelfreak
Copy link
Contributor

It might have something to do with r10k being in Bolt

But those are different rubies I think? Bolt isn't installed into the openvox Agent Ruby.

@nmburgan
Copy link
Member Author

nmburgan commented Sep 8, 2025

So the deal here is that when we ONLY install 8.23.0, then fast_gettext 4.1.0 is the only thing installed, and it is installed at /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems, and so when we go to install r10k, it sees it needs 2.4.0 and installs that automatically to /opt/puppetlabs/puppet/lib/ruby/gems/3.2.0/gems.

When we install r10k with pre-8.23.0 installed, then when r10k is installed it sees it 2.4.0 is already present at /opt/puppetlabs/puppet/lib/ruby/vendor_gems/gems and doesn't install it again. But then when we update the agent, the version in vendor_gems is now 4.1.0 and it isn't installed in the main gem path, so it just fails.

@nmburgan nmburgan changed the title Sanity tests for r10k and puppet service Test for r10k failure condition Sep 8, 2025
@nmburgan nmburgan force-pushed the r10k_service_tests branch 2 times, most recently from 51472c0 to b7975f4 Compare September 8, 2025 18:42
@nmburgan
Copy link
Member Author

nmburgan commented Sep 8, 2025

Version 8.23.0 of the agent updated fast_gettext to 4.1.0, which broke
r10k since it depends on gettext-setup, which pins fast_gettext to ~>
2.1. This simulates this upgrade condition. However, we should more
robustly test upgrades at some point in the future.
@nmburgan nmburgan merged commit b1d0d2f into main Sep 8, 2025
16 checks passed
@nmburgan nmburgan deleted the r10k_service_tests branch September 8, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants