-
Notifications
You must be signed in to change notification settings - Fork 392
Add assert_valid_signature utility #1444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add assert_valid_signature utility #1444
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1444 +/- ##
==========================================
+ Coverage 92.78% 92.98% +0.19%
==========================================
Files 78 78
Lines 2093 2081 -12
==========================================
- Hits 1942 1935 -7
+ Misses 151 146 -5
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @utgarda. Looking very good! I left a couple of comments, but it is almost ready.
@immrsd, can you also review this PR before we merge it? Note that we may need to refactor the util outside of the account package when separating the interface package as discussed, but let's merge this in the meantime. |
Add assert_valid_signature utility and use it for signature validation
fixes #1223
Added
assert_valid_signature
utility function in packages/account/src/utils.cairo that:Replaced duplicate signature validation logic in:
Integration test coming