feat: Integrate Midnight network support #175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openzeppelin-monitor ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shahnami
added
T-feature
zeljkoX
reviewed
May 21, 2025
zeljkoX
reviewed
May 21, 2025
zeljkoX
reviewed
May 21, 2025
zeljkoX
reviewed
May 21, 2025
zeljkoX
reviewed
May 21, 2025
zeljkoX
reviewed
May 21, 2025
zeljkoX
reviewed
May 21, 2025
|
I see that many checks are failing, seems like issue with midnight dependencies. |
MCarlomagno
reviewed
May 21, 2025
MCarlomagno
reviewed
May 21, 2025
MCarlomagno
approved these changes
May 21, 2025
The work on this started off a bit experimental, and started getting more shape in the follow-up PRs. I will be merging #218 and #240 in this one which should resolve the checks 🤞 Thanks for the review both @MCarlomagno and @zeljkoX ❤️ |
* chore: Implement BlockChainClient functions * chore: Add default events and txs functions to client * chore: Fix integration tests * chore: Working deserializer * test: Add tests for get_chain_type * chore: Upgrade to midnight-node 0.12.0 * revert: Upgrade to midnight-node 0.12.0 This reverts commit 77c1fbe. * chore: Add status to midnight tx and helper fns * chore: Fix errors and imports for midnight-node 0.12.0 * fix: Remove extra whitespace * fix: Remove untagged * fix: Transaction deserialization * chore: Add print statements * feat: Match on function signature * feat: Attempt at decrypting coininfo * chore: Successful decrypt with Seed * feat: Decrypt coininfo from viewing key config * chore: Cleanup * test: Fix monitor execution test for midnight * test: Add test coverage for Midnight transaction * test: Midnight client integration * chore: Add test builders for midnight * test: Add tests for midnight transport * fix: Number formatting * test: Add filter tests * chore: Normalise midnight hashes * chore: Add comment for why we test against empty strings * fix: Temporarily bypass deserialization * chore: Add comment * feat: Add monitoring on transaction status * chore: Cargo update * test: Add coverage for websocket transport * test: Add coverage for websocket and events * test: Fix existing tests * test: Implement ignored event tests * chore: Fix transaction status * test: Add test coverage for transaction status filtering * chore: Use finalised head for Midnight get_blocks * chore: Reverts commit a0176d8. * chore: Get latest finalised block * chore: Apply review suggestions * chore: Use * docs: Add Midnight documentation (#240) * docs: Add Midnight documentation and examples * fix: Remove config file * chore: Remove unused bip32 crate * test: Add test for secret string display value * fix: Telegram token resolving * chore: Update documentation with get_latest_block changes * docs: Update rpc endpoint for chain type * fix: Readme * chore: Cargo update
* refactor: Draft websockets and HTTP endpoint managers * test: Add integration tests for websocket logic * chore: Replace generic ws client with midnight specific * refactor: Use solely websocket for RPC requests (#253) * refactor: Use solely websocket for RPC requests * test: Fix tests and add helper methods * chore: Fix tests and ignore ones that rely on substrate * chore: Improve substrateclienttrait mocks * test: Add more coverage for transport * test: Add more test coverage for midnight client * docs: Add missing docstrings * test: Add coverage for monitor execution * test: Add coverage for filter_block * test: Fix remaining pool errors * chore: Remove outdated conditions and update docs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if let Err(ConfigError::ValidationError(err)) = result { | ||
| assert!(err | ||
| .message | ||
| .contains("Protocol: must start with one of: wss://, ws://")); |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.detect-insecure-websocket.detect-insecure-websocket
| if let Err(ConfigError::ValidationError(err)) = result { | ||
| assert!(err | ||
| .message | ||
| .contains("Protocol: must start with one of: http://, https://, wss://, ws://")); |
Check failure
Code scanning / Semgrep OSS
Semgrep Finding: javascript.lang.security.detect-insecure-websocket.detect-insecure-websocket
🚨 Bugbot Trial ExpiredYour team's Bugbot trial has expired. Please contact your team administrator to turn on the paid plan to continue using Bugbot. A team admin can activate the plan in the Cursor dashboard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://linear.app/openzeppelin-development/issue/PLAT-6492/add-network-and-models
This PR lays the foundational groundwork for integrating the Midnight network into the OpenZeppelin Monitor. It introduces essential models and initial test coverage to support Midnight's unique blockchain structure.
Key Changes:
Reviewer Focus Areas:
Merged PRs:
Testing Process
Checklist