Skip to content

add moe #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

add moe #2467

wants to merge 1 commit into from

Conversation

a31413510
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

PR changes

Description

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Aug 25, 2025

Thanks for your contribution!

lugimzzz
lugimzzz reviewed Aug 28, 2025
View reviewed changes
paddleformers/nn/moe/moe.py
from .moe_alltoall import moe_alltoall_forward
from .moe_allgather import moe_allgather_forward

class MOE(nn.Layer):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

接口设计是不是可以不设计成一个类而是继承generalinterface的方式，MOE类还是写在模型组网中

paddleformers/nn/moe/moe.py
from .moe_allgather import moe_allgather_forward

class MOE(nn.Layer):
_global_mapping = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

增加单测

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lugimzzz lugimzzz lugimzzz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a31413510 @lugimzzz