Skip to content

Conversation

Difers
Copy link

@Difers Difers commented Sep 24, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

  • 解决contiguous造成的save load 不接续问题
    load时对部分weight进行transpose造成Non-Contiguous
    导致在PipelineParallel init时,调用broadcast_sharding_parameters对parma.contiguous(), 造成参数错位

Copy link

paddle-bot bot commented Sep 24, 2025

Thanks for your contribution!

Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@f25a0f3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/transformers/conversion_utils.py 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2680   +/-   ##
==========================================
  Coverage           ?   29.51%           
==========================================
  Files              ?      311           
  Lines              ?    54942           
  Branches           ?        0           
==========================================
  Hits               ?    16214           
  Misses             ?    38728           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Difers
Copy link
Author

Difers commented Sep 25, 2025

/re-run all-failed

@Difers
Copy link
Author

Difers commented Sep 26, 2025

/re-run all-failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants