Add support for new socketables & Handle slot specific runes #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGG added more runes for wands and staves in the patch a couple weeks ago I don't particularly like how this is done as it requires more individual base checks each time a soul core or rune can go into a different base This becomes even more of a problem when trying to support the new talismans that can be socketed into gloves, boots, helmets, body armours and sceptres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1028
Started branch off of PR #1125 which added support for caster item sockets from v0.2.0. This PR expands on the new socketables from v0.2.1.
Description of the problem being solved:
Steps taken to verify a working solution:
Other Notes
The export script for soulcores now includes a step for checking a soul core base item against the 'soulcoresperclass' dat file. This file provides the information for those items with specific slot restrictions.
Socketables with more than one modline will be be added to the rune drop down list more than once. For examples, Talisman of Thruldana has a mod line to reduce poison duration and another mod line to give +1 poison stacks. There will be an entry in the Rune dropdown list for weapons, for the duration and then another for the stacks mod. The screenshot below illustrates this.
I updated the TradeQueryGenerator code to account for the new slot specific runes and it can rune and generate a new QueryMod fine, but I have no clue how to test this. I'm also not 100% sure that GGG has fully updated the stats.json for all of the new socketables.
Link to a build that showcases this PR:
This exports and reimports fine, but the mods don't populate fully on Maxroll.
https://maxroll.gg/poe2/pob/g63700ry
Screenshot:
Multi mod example:
Boots specific example:
