Support foreign keys #9
Open
+315
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two composite actions: * one tuple like, which executes the specified actions sequentially * one repeating composite, which executes a single action the specified N times These are used to improve the create table logic, which previously only created empty tables. Now the named create actions execute two sql statements, one which creates the table and one which does the insert. There's no transaction handling for now, as failure is okay: * if the create table fails, it throws an exception, and the second action (insert) is never executed * if the insert fails, that's okay, we end up with an empty table, that is the same as before. And most likely if it fails, that's because something already deleted the table There's also some related refactoring which allows the code to pass the table reference from the create command to the insert. This is not the prettiest code, it might need refactoring later when we firure out something better.
Before this commit partitioned tables had no primary keys: create table generated a serial column without a unique constraint, and a partition key without a unique constrant. As the partition key has a high range and has very small chance to generate duplicates, this commit removes the serial column from the partitioned tables, and makes the first column the primary key and partition key. This simplifies things as now all tables have a primary key in the first column, even if it isn't auto generated.
Also modify its behavior to throw an ActionException when it can't select a failed table, to improve the statistics. With this change if an action is skipped because a failed lookup, it will show up in the failure section of statistics instead of success.
While testing tables without primary keys could be useful, currently stormweaver relies on its existence at a few places. This change could be reverted once those parts are improved.
This commit adds foreign keys randomly to the test tables. For now it makes some assumptions, for example every table can have 0 or 1 foreign keys, and it's always the second column. The first column is also renamed simply to "id" for easier lookup in insert/update code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add foreign keys to stormweaver tests. This is a prerequisite for later PRs/features, which will add complex selects / views / materialized views to the testing.
This PR includes several commits:
dml.cpp