Updates -- fix pt for show replica command change, and mysql default … #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create user password plugin
ParveezBaig
reviewed
Jun 30, 2025
| fi | ||
| pt_ver=$(pt-table-checksum --version 2>/dev/null | awk '{print $NF}') | ||
| # Version-specific requirements | ||
| if [ "$VERSION" -ge "080000" ] || [ "$VERSION" -lt "080400" ] && [ $(normalize_version "$pt_ver") -lt $(normalize_version "3.0.9") ]; then |
There was a problem hiding this comment.
Shouldn't it be [ "$VERSION" -ge "080000" ] && [ "$VERSION" -lt "080400" ]
ParveezBaig
reviewed
Jun 30, 2025
| if [ "$VERSION_NUMERIC" -ge "$TARGET_VERSION" ]; then | ||
| $PS_DIR/bin/mysql -A -uroot -S $SOCKET -e "CREATE USER sysbench@'%' IDENTIFIED BY 'test';" | ||
| else | ||
| $PS_DIR/bin/mysql -A -uroot -S $SOCKET -e "CREATE USER sysbench@'%' IDENTIFIED WITH mysql_native_password BY 'test';" |
There was a problem hiding this comment.
For all 80 versions and above we are going without specifying any plugin which shall use the default plugin, this else condition will come into effect in run when it's less than 8.0 (ie, 5.7). Even in case of 5.7 we can create user without specifying the auth plugin and by default it would use mysql_native_password. IMO, just removing WITH mysql_native_password is enough from the create user query.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…create user password plugin