Modern config compat layers #476

meowora · 2025-06-30T22:45:15Z

Description

Adds a compat layer for some of the most popular config libraries.

Checklist

I made a clear description of what was changed
I stated why these changes were necessary
I updated documentation or said what needs to be updated
I made sure these changes are backwards compatible
This pull request is for one feature/bug fix

# Conflicts: # gradle.properties # gradle/libs.versions.toml # minecraft/build.gradle.kts # minecraft/src/main/java/org/polyfrost/oneconfig/internal/OneConfigMixinInit.java # modules/config-impl/src/main/kotlin/org/polyfrost/oneconfig/api/config/v1/internal/ConfigVisualizer.kt

# Conflicts: # gradle/libs.versions.toml # settings.gradle.kts

gradle/libs.versions.toml

minecraft/src/main/java/org/polyfrost/oneconfig/internal/OneConfigEarlyMixinInit.java

minecraft/src/main/java/org/polyfrost/oneconfig/internal/OneConfigMixinInit.java

minecraft/src/main/kotlin/org/polyfrost/oneconfig/internal/compat/MoulConfigCompat.kt

Wyvest · 2025-07-12T07:51:40Z

minecraft/src/main/kotlin/org/polyfrost/oneconfig/utils/v1/dsl/treeExtensions.kt

+import kotlin.reflect.KClass
+
+@Suppress("UNCHECKED_CAST")
+internal var Property<*>.visualizer: Class<out Visualizer>?


should we make this public?

idk your call

@nextdayy what do you think

...abric/src/main/java/org/polyfrost/oneconfig/internal/mixin/compat/modmenu/Mixin_ModMenu.java

...sions/1.16.5-fabric/src/main/kotlin/org/polyfrost/oneconfig/internal/compat/ModMenuCompat.kt

...sions/1.19.2-fabric/src/main/kotlin/org/polyfrost/oneconfig/internal/compat/RConfigCompat.kt

...sions/1.20.4-fabric/src/main/kotlin/org/polyfrost/oneconfig/internal/compat/RConfigCompat.kt

modules/relocator/src/main/kotlin/annotations/Moulconfig.kt

gradle/libs.versions.toml

minecraft/build.gradle.kts

minecraft/src/main/java/org/polyfrost/oneconfig/internal/OneConfigEarlyMixinInit.java

minecraft/src/main/kotlin/org/polyfrost/oneconfig/internal/compat/MoulConfigCompat.kt

nextdayy · 2025-07-12T10:39:23Z

i don't really see the point of the relocator system - can't you just have multiple mixin targets for the mixin(s) ?

Wyvest · 2025-07-12T17:07:17Z

i don't really see the point of the relocator system - can't you just have multiple mixin targets for the mixin(s) ?

we still need the main MoulConfigCompat class and we (meowora and i) concluded that doing it this way was the best

nextdayy · 2025-07-12T22:44:38Z

I personally think all usage of kotlin reflect (including KClass) should be removed and replaced with just java methods, as the kotlin ones spin up so many methods etc that are considerably slower and unnecessary here.

nextdayy · 2025-07-12T22:45:08Z

also I don't hate the compile time plugin stuff, but why not just use multi target accessors and mixins?

# Conflicts: # gradle/libs.versions.toml # modules/config-impl/api/config-impl.api # modules/hud/api/hud.api

meowora · 2025-07-22T12:38:06Z

also I don't hate the compile time plugin stuff, but why not just use multi target accessors and mixins?

It would make adding new moulconfig instances a lot more complicated/annoying, I personally also feel like that would be way too much work, especially since the compile time stuff already works.

meowora · 2025-07-22T12:38:57Z

I personally think all usage of kotlin reflect (including KClass) should be removed and replaced with just java methods, as the kotlin ones spin up so many methods etc that are considerably slower and unnecessary here.

I don't mind either, just a decision what i should do would be awesome :3

Wyvest · 2025-07-22T14:59:56Z

I personally think all usage of kotlin reflect (including KClass) should be removed and replaced with just java methods, as the kotlin ones spin up so many methods etc that are considerably slower and unnecessary here.

I don't mind either, just a decision what i should do would be awesome :3

i would prefer us using java reflection

meowora added 10 commits June 28, 2025 20:16

moulconfig stuff :3

28c4967

rconfig things :3

64d5374

fix: rconfig stuff :3

cce51dc

feat: yacl compat

f6b6e00

fix: categories, and random ids

ea7e5a1

fix: enum superclass is nullable

b6212dc

fix: rconfig categories

298ef0d

feat: mod menu compat :3

88e9e1d

revert: description stuff

b3af619

sometimes im not the brightest cat in the city

551078b

github-project-automation bot added this to OneConfig Jun 30, 2025

meowora added 2 commits July 1, 2025 00:46

Merge branch 'v1' into config-compat-layer

5939598

Update libs.versions.toml

5ce1182

Wyvest changed the title ~~moulconfig stuff :3~~ Modern config compat layers Jun 30, 2025

feat: remove native compat configs from modmenu

de6db86

This was linked to issues Jul 9, 2025

(feat): YACL integration #458

Open

(feat): ResourcefulConfig integration #459

Open

(feat): Cloth Config integration #460

Open

(feat): MoulConfig integration #461

Open

meowora added 3 commits July 9, 2025 12:38

meow

e4f41c0

feat: hide hidden elements

e7ce8c2

fix: moulconfig support

d8d4abd

meowora marked this pull request as ready for review July 10, 2025 08:24

meowora added 2 commits July 10, 2025 10:27

add dandelion lib

b708630

Wyvest moved this to In progress in OneConfig Jul 11, 2025

Wyvest removed a link to an issue Jul 11, 2025

(feat): Cloth Config integration #460

Open

meowora added 3 commits July 12, 2025 08:14

Merge remote-tracking branch 'polyfrost/v1' into config-compat-layer

7d6771b

# Conflicts: # gradle/libs.versions.toml # settings.gradle.kts

feat: icons

4fe58eb

update api bump

1b9180b

Wyvest requested review from Deftu and nextdayy July 12, 2025 07:20

Wyvest requested changes Jul 12, 2025

View reviewed changes

Deftu requested changes Jul 12, 2025

View reviewed changes

meowora added 2 commits July 22, 2025 11:54

Merge remote-tracking branch 'polyfrost/v1' into config-compat-layer

75a2cc6

# Conflicts: # gradle/libs.versions.toml # modules/config-impl/api/config-impl.api # modules/hud/api/hud.api

changes

d780c21

Merge branch 'v1' into config-compat-layer

237f240

meowora requested review from Deftu and Wyvest July 22, 2025 12:39

Deftu approved these changes Jul 22, 2025

View reviewed changes

Modern config compat layers #476

Are you sure you want to change the base?

Modern config compat layers #476

Uh oh!

Conversation

meowora commented Jun 30, 2025 • edited by Wyvest Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Wyvest Jul 12, 2025

Choose a reason for hiding this comment

Uh oh!

meowora Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Wyvest Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nextdayy commented Jul 12, 2025

Uh oh!

Wyvest commented Jul 12, 2025

Uh oh!

nextdayy commented Jul 12, 2025

Uh oh!

nextdayy commented Jul 12, 2025

Uh oh!

meowora commented Jul 22, 2025

Uh oh!

meowora commented Jul 22, 2025

Uh oh!

Wyvest commented Jul 22, 2025

Uh oh!

Uh oh!

meowora commented Jun 30, 2025 •

edited by Wyvest

Loading