Skip to content

Update alias doc strings #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update alias doc strings #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions PostHog/Classes/PHGPostHog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,8 @@ NS_ASSUME_NONNULL_BEGIN

@abstract
Merge two user identities, effectively connecting two sets of user data as one.
This may not be supported by all integrations.

@param alias The new ID you want to alias the existing ID to. The existing ID will be either the
previousId if you have called identify, or the anonymous ID.
@param alias The alias ID that you want to attach to the user
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's be more clear here - this needs to be the anonymous ID (that hasn't been merged with anything else). Please see https://posthog.com/docs/integrate/server/node#alias for example. what "alias ID" is is not clear.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't realize this was the case, I've asked a question here: PostHog/posthog-python#82 (comment)


@discussion
When you learn more about who the group is, you can record that information with group.
Expand Down