feat(llma): Support Gemini System Instructions #2254
Conversation
|
@cameronaziz is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| describe('parseGeminiSystemInstruction', () => { | ||
| describe('parseGeminiSystemInstruction', () => { |
There was a problem hiding this comment.
style: Duplicate nested describe blocks - the outer one is redundant
| describe('parseGeminiSystemInstruction', () => { | |
| describe('parseGeminiSystemInstruction', () => { | |
| describe('parseGeminiSystemInstruction', () => { |
| it('should filter out empty strings but keep non-empty ones', () => { | ||
| const instructions = ['', 'Valid instruction', ' ', 'Another valid'] | ||
| const result = parseGeminiSystemInstruction(instructions) | ||
| expect(result).toEqual([ | ||
| { role: 'system', content: 'Valid instruction' }, | ||
| { role: 'system', content: ' ' }, | ||
| { role: 'system', content: 'Another valid' }, | ||
| ]) | ||
| }) |
There was a problem hiding this comment.
logic: Test behavior differs from description - whitespace-only strings (' ') are kept, contradicting 'filter out empty strings'
packages/ai/src/sanitization.ts
Outdated
| const result = [] | ||
| for (const instruction of systemInstruction) { |
There was a problem hiding this comment.
style: Consider declaring explicit type for result array as Array<{ role: string; content: string }> to improve type safety
| const result = [] | |
| for (const instruction of systemInstruction) { | |
| const result: Array<{ role: string; content: string }> = [] | |
| for (const instruction of systemInstruction) { |
packages/ai/src/sanitization.ts
Outdated
| const result = [] | ||
| for (const part of parts) { |
There was a problem hiding this comment.
style: Consider declaring explicit type for result array as Array<{ role: string; content: string }> to improve type safety
| const result = [] | |
| for (const part of parts) { | |
| const result: Array<{ role: string; content: string }> = [] | |
| for (const part of parts) { |
cameronaziz
changed the title
cameronaziz
changed the title
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Problem
Currently, when sending events to PostHog for Gemini API calls, the system instructions are not included in the input data that gets tracked.
Changes
parseGeminiSystemInstructionfunction to parse various system instruction formats into standardized PostHog event formatgetPartTexthelper function to safely extract text content from various part formatssendEventToPostHogcalls in Gemini implementation to pass system instructionsformatInputForPostHogto accept and include system instructions in the input data sent to PostHogRelease info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file