-
Notifications
You must be signed in to change notification settings - Fork 22
update contributing guides #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below. |
I have some reservations about renaming several of these files because that will likely break existing links. Since we're not running full link checking right now, we may not spot all broken internal links, and may also inadvertently break external links to our content. So I think there needs to be a cost-benefit consideration. |
Heard @brian-rose I changed the file name back. I updated the language and a few other things. Any insight why it looks like I'm adding a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me; thanks for this!
Actually, from the history, With this PR got merged, we have a duplicate file now in the root as well. |
#519 was necessary to restore the correct URLs for pages on the portal site. Also keeping |
Updates project-wide contribution (changed name to reduce a frequent confusion I have), updates repo specific contribution guide, updates Cookbook guide to match MyST workflow and for clarity, and adds a lightweight Cookbook guide.