Skip to content

Bug fixes in the current parmest.py and example files #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 1, 2025

Conversation

slilonfe5
Copy link
Contributor

@slilonfe5 slilonfe5 commented Jun 19, 2025

Fixes # .

Summary/Motivation:

There is a raise error bug in the checks for experiment_outputs and unknown_parameters in the current parmest.py file: it fails to raise an error when the pyomo model used in the parmest example files lacks these attributes.

Changes proposed in this PR:

  • Add a raise in the try and except code that checks for experiment_outputs and unknown_parameters in the current parmest.py file
  • Add an experiment_outputs attribute to the pyomo model of the parmest examples that lack this attribute

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@slilonfe5 slilonfe5 marked this pull request as draft June 19, 2025 17:38
@slilonfe5 slilonfe5 marked this pull request as ready for review June 19, 2025 19:55
@slilonfe5
Copy link
Contributor Author

@adowling2 @djlaky @mrmundt @jsiirola I fixed the parmest raise error bug that we talked about at the Tuesday Dev meeting. This should be ready for review.

@blnicho blnicho moved this from Todo to Review In Progress in August 2025 Release Jun 23, 2025
@adowling2
Copy link
Member

@slilonfe5 Did you address all of the feedback? Is this ready for final review?

@adowling2 adowling2 moved this from Todo to Testing in ParmEst & Pyomo.DoE Development Jun 25, 2025
@slilonfe5
Copy link
Contributor Author

@adowling2 @djlaky @jsiirola @mrmundt I have addressed the feedback from John. This PR is ready for final review.

@sscini sscini moved this from Testing to Ready for final review in ParmEst & Pyomo.DoE Development Jun 27, 2025
@blnicho
Copy link
Member

blnicho commented Jul 1, 2025

@slilonfe5 did you see the review comments I left you a couple days ago? Let me know if you have any questions.

@slilonfe5
Copy link
Contributor Author

@blnicho Yes. Thank you for your feedback. I'm working on them now

Copy link
Contributor

@mrmundt mrmundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little comment - I think this is very close to ready.

@slilonfe5
Copy link
Contributor Author

slilonfe5 commented Jul 1, 2025

@mrmundt @blnicho @jsiirola @adowling2 @djlaky I have implemented the feedback from the final review. This PR is ready to be merged into the Pyomo main. I will move this to "Done" in the ParmEst & Pyomo.DoE Development board.

A kind reminder that this PR needs to be merged into the Pyomo main to enable PR #3535 to go through.

Thank you

@slilonfe5 slilonfe5 moved this from Ready for final review to Done in ParmEst & Pyomo.DoE Development Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Review In Progress to Reviewer Approved in August 2025 Release Jul 1, 2025
@blnicho blnicho merged commit bdcfa4f into Pyomo:main Jul 1, 2025
59 of 63 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in August 2025 Release Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

6 participants