-
Notifications
You must be signed in to change notification settings - Fork 547
Bug fixes in the current parmest.py and example files #3635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…in test_parmest.py file
@adowling2 @djlaky @mrmundt @jsiirola I fixed the |
@slilonfe5 Did you address all of the feedback? Is this ready for final review? |
@adowling2 @djlaky @jsiirola @mrmundt I have addressed the feedback from John. This PR is ready for final review. |
@slilonfe5 did you see the review comments I left you a couple days ago? Let me know if you have any questions. |
@blnicho Yes. Thank you for your feedback. I'm working on them now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little comment - I think this is very close to ready.
@mrmundt @blnicho @jsiirola @adowling2 @djlaky I have implemented the feedback from the final review. This PR is ready to be merged into the Pyomo main. I will move this to "Done" in the ParmEst & Pyomo.DoE Development board. A kind reminder that this PR needs to be merged into the Pyomo main to enable PR #3535 to go through. Thank you |
Fixes # .
Summary/Motivation:
There is a raise error bug in the checks for
experiment_outputs
andunknown_parameters
in the current parmest.py file: it fails to raise an error when the pyomo model used in the parmest example files lacks these attributes.Changes proposed in this PR:
raise
in the try and except code that checks forexperiment_outputs
andunknown_parameters
in the current parmest.py fileexperiment_outputs
attribute to the pyomo model of the parmest examples that lack this attributeLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: