Skip to content

Conversation

supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Aug 12, 2025

  • breaking seals Command
  • breaking makes Command implementations singletons
  • breaking makes Main's commands map immutable
  • converts Argument to a package-private record
  • eliminates ComposedArgument
  • fixes enigma-cli tests on windows

@supersaiyansubtlety supersaiyansubtlety self-assigned this Aug 12, 2025
@supersaiyansubtlety supersaiyansubtlety added the refactor improvements that don't impact functionality label Aug 12, 2025
@ix0rai ix0rai added the cli affects the enigma command-line interface label Aug 13, 2025
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for cleaning this code up ❤️

@supersaiyansubtlety supersaiyansubtlety changed the base branch from master to develop/2.7 August 18, 2025 22:51
@ix0rai ix0rai merged commit ce4fc32 into QuiltMC:develop/2.7 Aug 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli affects the enigma command-line interface refactor improvements that don't impact functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants