-
-
Notifications
You must be signed in to change notification settings - Fork 32
search-mappings
command
#282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
supersaiyansubtlety
wants to merge
36
commits into
QuiltMC:develop/2.7
Choose a base branch
from
supersaiyansubtlety:grep-command
base: develop/2.7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
search-mappings
command
#282
supersaiyansubtlety
wants to merge
36
commits into
QuiltMC:develop/2.7
from
supersaiyansubtlety:grep-command
+2,175
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1cf6d1
to
1e88409
Compare
1198f73
to
5ad642d
Compare
add MethodEntry::streamParameters and cache params implement GrepMappingsCommand
eliminate MemberTypeIndex
implement grep results limit
improve some javadocs and descriptions
make GrepMappingsTest DRYer and more specific add field grep tests add stubs for more test
fix check for whether an entry is mapped check LocalVariableEntry's to find params instead of iterating over method's params (fixes finding constructor params) add param tests to GrepMappingsTest
add more PredicateParser tests
add test mappings in preparation for access tests
fix stack overflow for getting type name of inner class
move boolean arg defaulting out of Argument (FillClassMappingsCommand handles its own fill-all default)
add findsARrayType test add sort tests
de4cf8b
to
a49e3c2
Compare
public Stream<LocalVariableDefEntry> streamParameters(EntryIndex index) { | ||
AccessFlags flags = index.getMethodAccess(this); | ||
return flags == null ? Stream.empty() : this.paramCache | ||
.computeIfAbsent(index, ignored -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this caching should be fine, but I want to bring attention to it just in case.
rebased, ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #280
Adds a
search-mappings
command for searching a project's mappings using one or more regular expressions.help entry:
arg help:
Also makes the
LocalVariableDefEntry
s ofMethodEntry
s' params obtainable and adds parameter indexing toEntryIndex
.Todo: