Skip to content

[release/2.3] check cmake #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: release/2.3
Choose a base branch
from
+4 −5
Draft

[release/2.3] check cmake #2407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6ad2a5d
check cmake
ethanwee1 Jul 24, 2025
77b20ed
Update build.sh
ethanwee1 Jul 24, 2025
8f11edd
upgrade cmake to 3.31.4
ethanwee1 Jul 25, 2025
43c9279
change in build.sh
ethanwee1 Jul 25, 2025
74ff9a1
Update install_cmake.sh
ethanwee1 Jul 25, 2025
f2fd38b
Update build.sh
ethanwee1 Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/docker/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ elif [[ "$image" == *linter* ]]; then
fi

# CMake 3.18 is needed to support CUDA17 language variant
CMAKE_VERSION=3.18.5
CMAKE_VERSION=3.31.4

_UCX_COMMIT=00bcc6bb18fc282eb160623b4c0d300147f579af
_UCC_COMMIT=7cb07a76ccedad7e56ceb136b865eb9319c258ea
Expand Down
4 changes: 1 addition & 3 deletions .ci/docker/common/install_cmake.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,5 @@ file="cmake-${CMAKE_VERSION}-Linux-x86_64.tar.gz"

# Download and install specific CMake version in /usr/local
pushd /tmp
curl -Os --retry 3 "https://cmake.org/files/${path}/${file}"
tar -C /usr/local --strip-components 1 --no-same-owner -zxf cmake-*.tar.gz
rm -f cmake-*.tar.gz
pip install cmake==3.31.4
popd
2 changes: 1 addition & 1 deletion .ci/pytorch/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

set -ex

export PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:$PATH
# Required environment variable: $BUILD_ENVIRONMENT
# (This is set by default in the Docker images we build, so you don't
# need to set it yourself.
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,5 @@ setuptools==69.5.1 ; python_version >= "3.12"
packaging==24.1
optree==0.9.1 ; python_version < "3.12"
optree==0.10.0 ; python_version >= "3.12"
cmake==3.31.4
lark==0.12.0