Skip to content

[AUTOGENERATED] [release/2.8] remove extra transposes in NHWC convolutions on MIOpen #2410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

okakarpa
Copy link
Collaborator

Cherry-pick of #2405

@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Jul 25, 2025

Jenkins build for a045703cd95453e1797686d3455fc915ce07a1ad commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

Copy link
Collaborator

@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the PR.

…ns on MIOpen (#2405)

remove aten::contiguous for NHWC convolutions

Tests:
-
nn/test_convolution.py::TestConvolutionNNDeviceTypeCUDA::test_conv_cudnn_nhwc_cuda_float32
-
nn/test_convolution.py::TestConvolutionNNDeviceTypeCUDA::test_conv_cudnn_nhwc_cuda_float16

Before:
<img width="1255" height="228" alt="image"
src="https://github.com/user-attachments/assets/b125ccab-00c2-4d3a-a341-4583e51d8d57"
/>

After:
<img width="874" height="153" alt="image"
src="https://github.com/user-attachments/assets/ec200754-3622-488e-8762-bff1c2d22818"
/>


Fixes SWDEV-526887
@dnikolaev-amd dnikolaev-amd force-pushed the autogenerated/release/2.8_cherry-pick_pr-2405 branch from ae7d478 to 3d95880 Compare August 12, 2025 18:08
@dnikolaev-amd dnikolaev-amd marked this pull request as ready for review August 12, 2025 18:08
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Aug 12, 2025

Jenkins build for 3d9588038531b0549249b5257169e003c3a5281e commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jithunnair-amd jithunnair-amd changed the title [AUTOGENERATED] [release/2.8] [rocm7.0_internal_testing] remove extra transposes in NHWC convolutions on MIOpen [AUTOGENERATED] [release/2.8] remove extra transposes in NHWC convolutions on MIOpen Aug 12, 2025
@jithunnair-amd jithunnair-amd merged commit 419fb69 into release/2.8 Aug 12, 2025
0 of 2 checks passed
@jithunnair-amd jithunnair-amd deleted the autogenerated/release/2.8_cherry-pick_pr-2405 branch August 12, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants