-
Notifications
You must be signed in to change notification settings - Fork 24
Find rocdecode - Updates for ROCm 7.0 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
kiritigowda
commented
Jun 22, 2025
- Use uniform find across all usecases
- Breaking change for - find rocDecode/rocDECODE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the codebase to use a consistent naming convention ("rocdecode") and bumps the version to 1.0.0 to support ROCm 7.0, introducing a breaking change from the old "rocDecode" API.
- Renames package names, include directories, and error messages from “rocDecode” to “rocdecode”.
- Updates version strings and associated configuration files.
- Revises CMake modules and build/test scripts to align with the new naming and versioning scheme.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
test/rocDecodeNegativeApiTests/CMakeLists.txt | Updated comments and error messages to use “rocdecode” consistently. |
test/CMakeLists.txt | Refactored find_package calls and messages to reflect new naming. |
src/rocdecode-host/CMakeLists.txt | Corrected a typo in the Threads error message and updated naming conventions. |
samples/* | Updated all sample CMakeLists.txt files to replace “rocDecode” with “rocdecode”. |
cmake_modules/rocdecode-config.cmake.in | Modified configuration file variables and included targets to use new names. |
README.md, CHANGELOG.md, CMakeLists.txt | Updated version numbers, messages, and documentation references to “rocdecode”. |
Comments suppressed due to low confidence (2)
CMakeLists.txt:43
- Ensure that the version update to 1.0.0 is clearly documented in release notes and user guidance to emphasize the breaking change from rocDecode to rocdecode.
set(VERSION "1.0.0")
CHANGELOG.md:5
- Make sure the changelog clearly highlights the breaking change in the API and naming convention, and that users are aware of the impact of migrating from rocDecode to rocdecode.
## rocdecode 1.0.0 for ROCm 7.0.0
@AryanSalmanpour please review this as a template change for all CV libraries. Suggest any changes or improvements required so we don't have to duplicate the fix for all the CV libs |