Skip to content

Another popping fix for your perusal #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

userpc0000
Copy link
Contributor

Hi Randy, I was still getting a lot of popping on pitch shifted noises in my game, and I think I've found the real source of the issue (overflowing the channel buffers). Cheers
-Brie

@RandyGaul
Copy link
Owner

Interesting! Thanks a lot. Do you have an audio clip, and a tiny C program to run that repros the issue? So I can see before/after. It's ok if not, it would just save me some time.

@RandyGaul
Copy link
Owner

Did you see this issue here and try this patch out by any chance? #403

@userpc0000
Copy link
Contributor Author

Hi hello! Well, I have a recording: https://www.youtube.com/watch?v=JH_AtYgAGZo
It's the pitch shifted 'clang' noises that were causing the popping... weirdly only audible in debug mode for the most part. I can send you the sfx on discord if you like!
(It seems to be the case that this out of bounds sampling is/was only an issue for files with a multiple of four amount of samples, which would make sense to me)
As for #403... I think I've been getting that glitch too, and didn't know what was causing it. I've just done that patch (more or less) and will report back!

@userpc0000
Copy link
Contributor Author

Okay, I've uploaded a more comprehensive patch addressing the resampler and looped sounds, which should also incoroporate the samples_needed patch as that variable is no longer modified in this version. I haven't tested it thoroughly yet so don't trust me too quickly.

@userpc0000
Copy link
Contributor Author

Please forgive my jank commits, I barely use github xD

@RandyGaul
Copy link
Owner

All good, I don't mind. Thanks a lot for taking some time to catch these sorts of bugs. Let me know when you want me to take a closer look and review things, whenever it's ready.

userpc0000 added 3 commits May 8, 2025 18:58
I almost panicked when I started hearing clicks again.
At least I hope so
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants