-
Notifications
You must be signed in to change notification settings - Fork 279
Another popping fix for your perusal #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Interesting! Thanks a lot. Do you have an audio clip, and a tiny C program to run that repros the issue? So I can see before/after. It's ok if not, it would just save me some time. |
Did you see this issue here and try this patch out by any chance? #403 |
Hi hello! Well, I have a recording: https://www.youtube.com/watch?v=JH_AtYgAGZo |
Okay, I've uploaded a more comprehensive patch addressing the resampler and looped sounds, which should also incoroporate the samples_needed patch as that variable is no longer modified in this version. I haven't tested it thoroughly yet so don't trust me too quickly. |
Please forgive my jank commits, I barely use github xD |
All good, I don't mind. Thanks a lot for taking some time to catch these sorts of bugs. Let me know when you want me to take a closer look and review things, whenever it's ready. |
I almost panicked when I started hearing clicks again.
At least I hope so
Hi Randy, I was still getting a lot of popping on pitch shifted noises in my game, and I think I've found the real source of the issue (overflowing the channel buffers). Cheers
-Brie