Skip to content

🐛 Correct field name for affect fetching #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2025
Merged

🐛 Correct field name for affect fetching #589

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d910c9
🐛 Correct field name for affect fetching
superbuggy Jul 9, 2025
4326e52
💡 Note transition for field name change
superbuggy Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/services/AffectService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import type { ZodAffectType, ZodAffectCVSSType } from '@/types/';
import { beforeFetch } from './FlawService';

export async function getAffects(cveOrUuid: string) {
const field = isCveValid(cveOrUuid) ? 'cve_id' : 'flaw__uuid';
const field = isCveValid(cveOrUuid) ? 'flaw__cve_id' : 'flaw__uuid';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that went totally unseen on the review, good catch!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucky we did! I think #590 can help to solve this potential hazard

// TODO: replace line above with line below after OSIDB-4293 is merged
// const field = isCveValid(cveOrUuid) ? 'cve_id' : 'flaw__uuid';
return osidbFetch({
method: 'get',
url: '/osidb/api/v1/affects',
Expand Down