♻️ AuthStore refactor #613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-Valen
force-pushed
the
refactor/AuthStore
branch
from
0fb1542 to
fc28bb3
Compare
C-Valen
force-pushed
the
refactor/AuthStore
branch
from
fc28bb3 to
7afbe40
Compare
C-Valen
force-pushed
the
refactor/AuthStore
branch
from
7afbe40 to
b3680c1
Compare
superbuggy
reviewed
Sep 25, 2025
| await userStore.login('skynet', 'terminator'); | ||
| const { useAuthStore } = await import('../AuthStore'); | ||
| const authStore = useAuthStore(); | ||
| await authStore.login('skynet', 'terminator'); |
superbuggy
reviewed
Sep 25, 2025
|
|
||
| expect(() => { | ||
| userStore.accessToken = 'invalid'; | ||
| authStore.accessToken = 'invalid' as any; |
There was a problem hiding this comment.
why does TS complain here? Seems like it should be fine with being a string
| userStore.accessToken = undefined; | ||
| expect(userStore.isAccessTokenExpired()).toBe(true); | ||
| const authStore = useAuthStore(); | ||
| authStore.accessToken = undefined as any; |
There was a problem hiding this comment.
Suggested change
| authStore.accessToken = undefined as any; | |
| authStore.accessToken = null; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthStore refactor
Checklist:
Summary:
Separate authentication logic from
UserStoreinto a dedicatedAuthStorefor better separation of concerns.Changes:
✨ New AuthStore: Handles login/logout, token management, and authentication state
♻️ UserStore refactoring: Removed auth logic, kept only user data management
♻️ Component updates: Login, Navbar, and other components now use AuthStore
♻️ Service updates: OsidbAuthService switched to AuthStore
♻️ Composable updates: useSessionWarning now uses AuthStore
♻️ Router updates: Authentication checks moved to AuthStore
✅ Test updates: All tests updated for new store separation
Considerations:
Extension of #598 to make an
AuthSotrethat integrates into the user store for better code organization.