Skip to content

RDSC-3561 Add custom keystore and truststore for the jedis client in redis sink #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 3.0.8
Choose a base branch
from

Conversation

nange10v
Copy link

@nange10v nange10v commented May 13, 2025

This change introduces additional configuration options for specifying custom keystore/truststore for the jedis client in redis sink. This allows the client to use different keys and certificates than the default ones passed to the JVM.

This change updates the Jedis client to version 6.0.0. and takes advantage of the newly introduced SSL options.
The options are applied only if redis.ssl.enabled is true.

Configuration properties for each new SSL options:
redis.ssl.truststore.path: Specifies the path to the truststore file used for SSL.
redis.ssl.truststore.password: Specifies the password for the truststore file.
redis.ssl.truststore.type: Specifies the type of the truststore (e.g., JKS, PKCS12) (default: JKS).
redis.ssl.keystore.path: Specifies the path to the keystore file used for SSL.
redis.ssl.keystore.password: Specifies the password for the keystore file.
redis.ssl.keystore.type: Specifies the type of the keystore (e.g., JKS, PKCS12) (default: JKS).

see https://redislabs.atlassian.net/browse/RDSC-3561

@nange10v nange10v self-assigned this May 13, 2025
@nange10v nange10v requested review from peperon and Copilot May 13, 2025 10:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for custom SSL configurations for the Jedis client in the Redis sink. It introduces new configuration options for specifying custom keystore and truststore settings, updates the Redis client connection logic, and bumps the Jedis dependency version to 6.0.0.

  • The Redis connection constructors in both the offset store and schema history have been updated to use a unified configuration object.
  • New configuration fields and accessors for truststore and keystore properties have been added in the common configuration.
  • The SSL configuration in the Redis connection now optionally applies custom SslOptions when needed.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
RedisOffsetBackingStore.java Updated to use the new RedisConnection constructor with configuration object.
RedisSchemaHistory.java Updated to use the new RedisConnection constructor with configuration object.
RedisConnection.java Refactored to use final fields, added support for custom SSL options with keystore/truststore, and adjusted SSL parameter configuration.
RedisCommonConfig.java Added new fields and accessors for custom truststore/keystore settings.
pom.xml Jedis version updated from 4.1.1 to 6.0.0 to support the new SSL options.

@nange10v nange10v changed the title Add custom keystore and truststore for the jedis client in redis sink RDSC-3561 Add custom keystore and truststore for the jedis client in redis sink May 13, 2025
Copy link

@stoyanr stoyanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Shouldn't we add unit tests for the newly added properties?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants