PoC: allow overriding currencySymbol from a backend-provided ruleset #5663

rickvdl · 2025-10-15T14:16:37Z

We're having an issue related to currency formatting behavior in Romania (and possibly a few other currencies), internal discussion can be found here.

But some context: when using the Romanian Storefront, and a Romanian locale (ro_RO) prices are formatted as 1,23 RON, which is correct, but the more conventional way to write this in Romanian (according to reports) is 1,23 lei.

underlyingSK2Product.displayPrice uses the more common lei rather than RON, however the priceFormatter we create in SK2StoreProduct.swift through priceFormatterProvider.priceFormatterForSK2 based on the currency code and locale given to us by StoreKit creates strings using RON instead. This is causing discrepancies between localizedPriceString and the price strings we generate using the formatter (for example pricePerMonth) which looks confusing on the paywall especially.

After some research and discussions it looks like we can't get the NumberFormatter API to mimic the behavior of StoreKit, and thus we've been looking into an alternative approach.

We came up with a backend driven approach where we (given a ruleset) provide the option to override the currencySymbol for specific currency codes, given a storekit storefront (similar to what we already do for paywall localizations).

This PR is just a PoC outlining the rough workings of this approach. Happy to hear any feedback

RevenueCat-Danger-Bot · 2025-10-15T14:19:13Z

	1 Error
🚫	Label the PR using one of the change type labels. If you are not sure which label to use, choose pr:other.

Label	Description
pr:feat	A new feature. Use along with pr:breaking to force a major release.
pr:fix	A bug fix. Use along with pr:force_minor to force a minor release.
pr:other	Other changes. Catch-all for anything that doesn't fit the above categories. Releases that only contain this label will not be released. Use along with pr:force_patch, or pr:force_minor to force a patch or minor release.
pr:RevenueCatUI	Use along any other tag to mark a PR that only contains RevenueCatUI changes
pr:next_release	Preparing a new release
pr:dependencies	Updating a dependency
pr:phc_dependencies	Updating purchases-hybrid-common dependency
pr:changelog_ignore	The PR will not be included in the changelog. This label doesn't determine the type of bump of the version and must be combined with `pr:feat`, `pr:fix` or `pr:other`.

Generated by 🚫 Danger

emerge-tools · 2025-10-15T14:19:25Z

4 builds increased size

Name	Version	Download	Change	Install	Change	Approval
RevenueCat com.revenuecat.PaywallsTester	1.0 (1)	14.9 MB	⬆️ 33.8 kB (0.23%)	51.8 MB	⬆️ 135.2 kB (0.26%)	N/A
RevenueCat com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad	1.0 (1)	12.1 MB	⬆️ 29.3 kB (0.24%)	44.5 MB	⬆️ 126.7 kB (0.29%)	N/A
RevenueCat com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac	1.0 (1)	12.1 MB	⬆️ 29.3 kB (0.24%)	44.5 MB	⬆️ 126.7 kB (0.29%)	N/A
RevenueCat com.revenuecat.PaywallsTester.mac-native	1.0 (1)	10.6 MB	⬆️ 24.5 kB (0.23%)	38.9 MB	⬆️ 126.9 kB (0.33%)	N/A

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 135.2 kB (0.26%)
Total download size change: ⬆️ 33.8 kB (0.23%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 50.9 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.CurrencySymbolO...	⬆️ 4.8 kB
Code Signature	⬆️ 3.7 kB
DYLD.Exports	⬆️ 3.4 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.Objc Metadata	⬆️ 1.3 kB

View Treemap

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 126.7 kB (0.29%)
Total download size change: ⬆️ 29.3 kB (0.24%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 45.3 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.CurrencySymbolO...	⬆️ 4.6 kB
DYLD.Exports	⬆️ 3.4 kB
Code Signature	⬆️ 2.8 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.Objc Metadata	⬆️ 1.2 kB

View Treemap

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 126.7 kB (0.29%)
Total download size change: ⬆️ 29.3 kB (0.24%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 45.3 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.CurrencySymbolO...	⬆️ 4.6 kB
DYLD.Exports	⬆️ 3.4 kB
Code Signature	⬆️ 2.8 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.Objc Metadata	⬆️ 1.2 kB

View Treemap

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-native

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 126.9 kB (0.33%)
Total download size change: ⬆️ 24.5 kB (0.23%)

Largest size changes

Item	Install Size Change
DYLD.String Table	⬆️ 45.3 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.CurrencySymbolO...	⬆️ 4.6 kB
DYLD.Exports	⬆️ 3.4 kB
Code Signature	⬆️ 3.1 kB
📝 RevenueCat.CurrencySymbolOverridingPriceFormatter.Objc Metadata	⬆️ 1.2 kB

View Treemap

🛸 Powered by Emerge Tools

Comment trigger: Size diff threshold of 100.00kB exceeded

emerge-tools · 2025-10-15T14:23:51Z

📸 Snapshot Test

7 modified, 868 unchanged

Name	Modified	Unchanged	Approval
RevenueCat com.revenuecat.PaywallsTester.mac-native	7	160	⏳ Needs approval
RevenueCat com.revenuecat.PaywallsTester	0	236	N/A
RevenueCat com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad	0	236	N/A
RevenueCat com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac	0	236	N/A

🛸 Powered by Emerge Tools

Sources/Networking/Responses/OfferingsResponse.swift

fire-at-will · 2025-10-15T20:04:49Z

Sources/Misc/PriceFormatterProvider.swift

 /// A `NumberFormatter` provider class for prices.
 /// This provider caches the formatter to improve the performance.
-final class PriceFormatterProvider: Sendable {
+public final class PriceFormatterProvider: Sendable {


This probably doesn't need to be public public if it's just RevenueCatUI using this, I'd probably add @_spi(Internal) so it's only used by RevenueCatUI

Suggested change

public final class PriceFormatterProvider: Sendable {

@_spi(Internal) public final class PriceFormatterProvider: Sendable {

Unfortunately I don't think this will work, the SK2 product initializer in StoreProduct is public and has this type in the function signature. Will make sure to bring this up in the actual PR

fire-at-will · 2025-10-15T20:17:02Z

Sources/Misc/PriceFormatterProvider.swift

+                return formatter
+            }
+
+            if let formatter = formatter, formatter.currencyCode == currencyCode, formatter.locale == locale {


In the logic here:

if let formatter = formatter as? CurrencySymbolOverridingPriceFormatter, formatter.currencyCode == currencyCode, formatter.locale == locale, formatter.currencySymbolOverride == currencySymbolOverride { return formatter } if let formatter = formatter, formatter.currencyCode == currencyCode, formatter.locale == locale { return formatter }

The first if checks if the formatter is a CurrencySymbolOverridingPriceFormatter and that all of the parameters match. If it fails, the second if still returns the formatter as long as the formatter's currency code & locale match.

Could this lead to a bug where if the formatter is a CurrencySymbolOverridingPriceFormatter, the overrides don't match, but the currency code & locale do, we return a CurrencySymbolOverridingPriceFormatter that doesn't match the current context?

Good catch, I think you're right. Addressed this :)

fire-at-will · 2025-10-15T20:20:58Z

Sources/Misc/PriceFormatterProvider.swift

+    }
+
+    private func formatter(for rule: PriceFormattingRuleSet.CurrencySymbolOverride.PluralRule) -> NumberFormatter {
+        if let formatter = numberFormatterCache[rule] {


Love this 👏👏

fire-at-will · 2025-10-15T20:27:23Z

Sources/Networking/Responses/OfferingsResponse.swift

    let placements: Placements?
    let targeting: Targeting?
    let uiConfig: UIConfig?
+    let config: Config?


Nit: we should probably name this something more specific, like priceFormattingConfig, in case we decide to add other configs in the future

Good one, I figured we might want to use this as a 'config envelope' to also hold future configuration values, in order to avoid having to update all initializers and mocks again. But I will make sure to bring this up in my PR and ask for the team's opinion on this as well

…urrent storefront

fire-at-will reviewed Oct 15, 2025

View reviewed changes

rickvdl added 4 commits October 17, 2025 08:43

PoC: allow overriding currencySymbol from a backend-provided ruleset

ec5ec25

Cleaner way of getting the currency symbol override ruleset for the c…

226475e

…urrent storefront

Code cleanup

ae7a5a4

Fixed a case where the wrong formatter might be used

7d6b087

rickvdl force-pushed the rickvdl/currency-symbol-ruleset-override-poc branch from d5403b6 to 7d6b087 Compare October 17, 2025 07:01

rickvdl mentioned this pull request Oct 17, 2025

Implement Price formatting ruleset for overriding currency symbol's per storefront and currency #5676

Draft

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PoC: allow overriding currencySymbol from a backend-provided ruleset #5663

PoC: allow overriding currencySymbol from a backend-provided ruleset #5663

rickvdl commented Oct 15, 2025

Uh oh!

RevenueCat-Danger-Bot commented Oct 15, 2025

Uh oh!

emerge-tools bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

emerge-tools bot commented Oct 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

fire-at-will Oct 15, 2025

Uh oh!

rickvdl Oct 17, 2025

Uh oh!

fire-at-will Oct 15, 2025

Uh oh!

rickvdl Oct 17, 2025

Uh oh!

fire-at-will Oct 15, 2025

Uh oh!

fire-at-will Oct 15, 2025

Uh oh!

rickvdl Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public final class PriceFormatterProvider: Sendable {
	@_spi(Internal) public final class PriceFormatterProvider: Sendable {

PoC: allow overriding currencySymbol from a backend-provided ruleset #5663

Are you sure you want to change the base?

PoC: allow overriding currencySymbol from a backend-provided ruleset #5663

Conversation

rickvdl commented Oct 15, 2025

Uh oh!

RevenueCat-Danger-Bot commented Oct 15, 2025

Uh oh!

emerge-tools bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

4 builds increased size

RevenueCat 1.0 (1)com.revenuecat.PaywallsTester

RevenueCat 1.0 (1)com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad

RevenueCat 1.0 (1)com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac

RevenueCat 1.0 (1)com.revenuecat.PaywallsTester.mac-native

Uh oh!

emerge-tools bot commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📸 Snapshot Test

7 modified, 868 unchanged

Uh oh!

Uh oh!

fire-at-will Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

rickvdl Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

fire-at-will Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

rickvdl Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

fire-at-will Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

fire-at-will Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

rickvdl Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

emerge-tools bot commented Oct 15, 2025 •

edited

Loading

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-scaled-to-match-ipad

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-catalyst-optimized-for-mac

RevenueCat 1.0 (1)
com.revenuecat.PaywallsTester.mac-native

emerge-tools bot commented Oct 15, 2025 •

edited

Loading