-
Notifications
You must be signed in to change notification settings - Fork 2
Issue #100: Delete contents of temp_dir without conflicts. #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…directories. still have to manually delete the empty UUID directories.
|
Currently, this mostly works. It creates a new folder with a UUID-based name, and properly puts all the temporary files for that pipeline run inside that folder, then deletes the contents of the folder at the end. However, it does not delete the folder itself, so you end up with a lot of empty folders in |
|
@wmwv @rknop I think this is a reasonable time to return to the temp_dir/intermediate/scratch conversation. If we want to keep temp_dir really as a temporary directory with throwaway files, I can leave this as-is (i.e. the folder created within |
|
Punt and merge. |
|
To have human-readable and identifiable directories implies that we have some tracking of processing. So the concept of "run", "collection", "campaign" or some other organized way of tracking what we're doing and whether things should overwrite, dependent on, or be total separate. I don't think we're ready to have this discussion yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Generate a unique folder with a UUID-based name within
self.temp_dirso that there are no conflicts with deleting the contents ofself.temp_dirwhen multiple jobs are launched.