Skip to content

transpose intermediate file matrices when output to save #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

transpose intermediate file matrices when output to save #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f2f1a3
transpose intermediate file matrices when output to save
laldoroty Aug 5, 2025
4589cfd
changelog
laldoroty Aug 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/115.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Per the adopted convention in SFFT, all input and output arrays should be transposed. The output intermediate file arrays were not transposed when saving to disk. Now they are.
16 changes: 8 additions & 8 deletions phrosty/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,38 +730,38 @@ def log_fits_write_error( savepath, x ):

write_filepaths = {'aligned': [['img',
templ_image.image.name,
cp.asnumpy(sfftifier.PixA_resamp_object_GPU),
cp.asnumpy(sfftifier.PixA_resamp_object_GPU.T),
sfftifier.hdr_target],
['var',
templ_image.image.name,
cp.asnumpy(sfftifier.PixA_resamp_objectVar_GPU),
cp.asnumpy(sfftifier.PixA_resamp_objectVar_GPU.T),
sfftifier.hdr_target],
['psf',
templ_image.image.name,
cp.asnumpy(sfftifier.PSF_resamp_object_GPU),
cp.asnumpy(sfftifier.PSF_resamp_object_GPU.T),
sfftifier.hdr_target],
['detmask',
sci_image.image.name,
cp.asnumpy(sfftifier.PixA_resamp_object_DMASK_GPU),
cp.asnumpy(sfftifier.PixA_resamp_object_DMASK_GPU.T),
sfftifier.hdr_target]
],
'convolved': [['img',
f'{conv_sci_name[:-5]}_{conv_templ_name}',
cp.asnumpy(sfftifier.PixA_Ctarget_GPU),
cp.asnumpy(sfftifier.PixA_Ctarget_GPU.T),
sfftifier.hdr_target],
['img',
f'{conv_templ_name[:-5]}_{conv_sci_name}',
cp.asnumpy(sfftifier.PixA_Cresamp_object_GPU),
cp.asnumpy(sfftifier.PixA_Cresamp_object_GPU.T),
sfftifier.hdr_target]
],
'diff': [['img',
f'{conv_sci_name[:-5]}_{conv_templ_name}',
cp.asnumpy(sfftifier.PixA_DIFF_GPU),
cp.asnumpy(sfftifier.PixA_DIFF_GPU.T),
sfftifier.hdr_target]
],
'decorr': [['kernel',
sci_image.image.name,
cp.asnumpy(sfftifier.FKDECO_GPU),
cp.asnumpy(sfftifier.FKDECO_GPU.T),
sfftifier.hdr_target]
]
}
Expand Down